Update spack recipes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age, other cleanup of python support
Can use external googletest, but this requires depending on googletest as a "build" dependency as well, which makes it a required dependency. Using the bundled googletest allows using it only when required.
msimberg
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
No blocking comments from me.
I can't very deeply review the github workflows since I've never used this type of workflow myself before, nor have I used the package index. However, it looks reasonable enough and nicely abstracted to my naive eye (and I'm learning about quite a few interesting features at the same).
There's a minor change that could be applied to the ghex package that I realize only now. Otherwise no real comments on the spack packages since I already made all changes that I felt were useful in boeschf#1.
Co-authored-by: Mikael Simberg <[email protected]>
msimberg
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.