Feat(#105) housework info update #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존에는 관계 해제 후 관계로 조회한 투두를DELETE 상태로 변경해줘서 아무일도 일어나지 않았었다. 관계 해제 전에 DELETE로 변경해줘야 했다.
2 tasks
수정 목록
|
ghdcksgml1
requested changes
Nov 22, 2023
|
|
||
| // houseworkInfo와 일치하는 값들을 삭제한다. | ||
| @Transactional |
There was a problem hiding this comment.
이 메서드를 사용하는 서비스단에 이미 붙어있어서 호출하는 쪽의 트랜잭션에 묶여서 따로 붙여주지 않아도 될 줄 알았어요. 붙여야하는 걸까요??? 😅
There was a problem hiding this comment.
단순 조회 기능이 아닌 삭제를 하는 메서드라서 안전하게 삭제하려면 붙여줘야 하겠군요!
|
|
||
|
|
||
| @Override | ||
| public boolean isSameHouseworkMemberIdAndGroupMemberId(HouseworkInfo info, List<Long> groupIdList) { |
There was a problem hiding this comment.
Interface의 파라미터명과 일치하지 않네요 ㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
테스트
관련 이슈
#105