Fix converting long Text to JS string #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtolly
referenced
this pull request
in mtolly/hs-cordova
Dec 28, 2014
will probably switch to lazy text. funnily enough this breaks the DataURL camera test, whereas it worked with String.
luite
added a commit
that referenced
this pull request
Dec 30, 2014
Fix converting long Text to JS string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In (at least) iOS Safari, converting a long Text (over 65536 chars) to a JS string fails due to
applying a large array as function arguments toString.fromCharCode; see https://bugs.webkit.org/show_bug.cgi?id=80797.This breaks the array up into chunks that fit under this limit, concatenating the strings as it goes.
A quick search says there might be a few more
String.fromCharCode.applycalls nearby with the same issue, but this patch successfully fixed the conversion for me.