Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: account for lookup tables when checking shared memory size #11502

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

jeffbolznv
Copy link
Collaborator

I tested this with shared memory size forced to 32KB or 16KB and verified test-backend-ops was fine.

CC @remyoudompheng

@jeffbolznv jeffbolznv requested a review from 0cc4m January 29, 2025 23:51
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jan 29, 2025
@jeffbolznv
Copy link
Collaborator Author

I've rebased this and resolved the iq4_xs conflicts.

Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0cc4m 0cc4m merged commit 98f6b0f into ggerganov:master Feb 9, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants