Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rust-cache-version #5040

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jan 11, 2024

rust-cache has started taking 2m30s to finish instead of 11 seconds. They had a release 6 hours ago, this pins to the sha of the previous version.

Will file upstream Swatinem/rust-cache#182

@cwfitzgerald cwfitzgerald force-pushed the pin-rust-cache-version branch from 82f8261 to b395e10 Compare January 11, 2024 01:33
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 11, 2024 01:36
@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 11, 2024 01:36
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 11, 2024 01:39
@cwfitzgerald cwfitzgerald merged commit 2512b2d into gfx-rs:trunk Jan 11, 2024
27 checks passed
@ErichDonGubler
Copy link
Member

@cwfitzgerald: Is an issue filed on the speed regression? I wonder if some defaults changes for the bucketing, or is this actually just a slower cache rehydration?

@cwfitzgerald
Copy link
Member Author

I linked it in the body, the underlying issue seems to be node20 actions take a long time to be detected as "finished"

@cwfitzgerald cwfitzgerald deleted the pin-rust-cache-version branch January 11, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants