Skip to content

Commit

Permalink
Split up features. (#6905)
Browse files Browse the repository at this point in the history
Splits up features into wgpu & webgpu features.
  • Loading branch information
Vecvec authored Feb 8, 2025
1 parent 4675393 commit 6558deb
Show file tree
Hide file tree
Showing 4 changed files with 1,372 additions and 821 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ Bottom level categories:
- Rename `instance_id` and `instance_custom_index` to `instance_index` and `instance_custom_data` by @Vecvec in
[#6780](https://github.com/gfx-rs/wgpu/pull/6780)

##### Split up `Features` internally

Internally split up the `Features` struct and recombine them internally using a macro. There should be no breaking
changes from this. This means there are also namespaces (as well as the old `Features::*`) for all wgpu specific
features and webgpu feature (`FeaturesWGPU` and `FeaturesWebGPU` respectively) and `Features::from_internal_flags` which
allow you to be explicit about whether features you need are available on the web too.

By @Vecvec in [#6905](https://github.com/gfx-rs/wgpu/pull/6905).

##### Refactored internal trace path parameter

Refactored some functions to handle the internal trace path as a string to avoid possible issues with `no_std` support.
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/device.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async fn request_device_error_message() {
let expected = "TypeError";
} else {
// This message appears whenever wgpu-core is used as the implementation.
let expected = "Unsupported features were requested: Features(";
let expected = "Unsupported features were requested: Features {";
}
}
assert!(device_error.contains(expected), "{device_error}");
Expand Down
Loading

0 comments on commit 6558deb

Please sign in to comment.