Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brlaser: Update to v6.2.7 #4879

Merged
merged 1 commit into from
Jan 26, 2025
Merged

brlaser: Update to v6.2.7 #4879

merged 1 commit into from
Jan 26, 2025

Conversation

davidjharder
Copy link
Member

@davidjharder davidjharder commented Jan 21, 2025

Summary

New printers added:

  • Brother DCP-7010
  • Brother DCP-B7500D series
  • Brother DCP-L2560DW series
  • Brother HL-2240 series
  • Brother HL-2260D
  • Brother HL-5140 series
  • Brother HL-5370DW series
  • Brother HL-5450DN series
  • Brother HL-L2402D
  • Brother MFC-8440
  • Brother MFC-L2690DW
  • Brother HL-L2400DW
  • Brother HL-L2405W

Full changelog here

Packaging

  • Added patch and sed fixup to address duplex printing issues particular to Solus

Test Plan

  • Check duplex printing with long and short edge

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitoring.yaml : )

@QORTEC
Copy link

QORTEC commented Jan 21, 2025

Just wanted to note that there may be issues with this version of brlaser on Solus.
Currently I cannot print duplex long edge using this version of the driver.

Print Setting Results in
Duplex long-edge Duplex short-edge
Duplex short-edge Duplex short-edge
Simplex Simplex

Commonly asked questions:

  • Yes my system is fully updated (Stable).
  • My printers model is HL-2270DW
  • Built via solbuild against commit 331da02cf9d495451643637ce7ccbe6434a6c2e7
  • I installed the package using the --reinstall flag
  • I deleted my printer and re-added via Print settings (system-config-printer)

More detailed info:
Owl-Maintain/brlaser#26

I would suggest testing:

  • Duplex Long-edge
  • Duplex Short-edge
  • Simplex

@davidjharder davidjharder marked this pull request as draft January 21, 2025 18:37
@davidjharder
Copy link
Member Author

Draft until duplex situation is clarified

@davidjharder
Copy link
Member Author

@QORTEC
I can confirm the issue when using an HL-L2320D:

6.2.7: Prints duplex short-side when short-side OR long-side is selected
6.2.6: Prints duplex short-side and long-side as expected
Single side not affected

@QORTEC
Copy link

QORTEC commented Jan 22, 2025

@davidjharder
I know what code needs to be modified to make the drive work as expected on Solus. I would be happy to create a patch file if that's what's desired.

I just wanted to note that the issue is CUPS not functioning as expected. Look at Owl-Maintain/brlaser#26 for more details.

I've personally built and tested brlaser on a Fedora Workstation LiveCD and it's working as expected there.

@davidjharder
Copy link
Member Author

A patch would be great

@QORTEC
Copy link

QORTEC commented Jan 22, 2025

Patch file for fixing duplex long edge on Solus: 1000-solus-duplex.patch.txt

You may want to change the printers from Duplex rotated to Duplex normal:
sed -i brlaser.drv.in -e 's|Duplex rotated|Duplex normal|g'

Setting the printers to Duplex normal should avoid any further disruption if CUPS starts respecting the duplex settings in brlaser.drv at some point in the future.

@davidjharder
Copy link
Member Author

This is excellent. Thanks!

**Summary**

New printers added:

- Brother DCP-7010
- Brother DCP-B7500D series
- Brother DCP-L2560DW series
- Brother HL-2240 series
- Brother HL-2260D
- Brother HL-5140 series
- Brother HL-5370DW series
- Brother HL-5450DN series
- Brother HL-L2402D
- Brother MFC-8440
- Brother MFC-L2690DW
- Brother HL-L2400DW
- Brother HL-L2405W

Full changelog [here](https://github.com/Owl-Maintain/brlaser/releases/tag/v6.2.7)

**Packaging**

- Added patch and sed fixup to address duplex printing issues particular to Solus
@davidjharder davidjharder marked this pull request as ready for review January 25, 2025 19:01
@davidjharder
Copy link
Member Author

Both varieties of duplex now work as expected

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@malfisya malfisya merged commit 3b5c1b6 into main Jan 26, 2025
1 check passed
@malfisya malfisya deleted the brlaser branch January 26, 2025 22:29
@malfisya malfisya added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants