feat(multi-query): Add charts and tables to multi query mode #85303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 20.63kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
edwardgou-sentry
approved these changes
Feb 18, 2025
| @@ -130,8 +131,9 @@ function getUpdatedLocationWithQueries( | |||
| location: Location, | |||
| queries: WritableExploreQueryParts[] | null | undefined | |||
| ) { | |||
| let targetQueries: string[] | null = null; | |||
There was a problem hiding this comment.
nit: I think you can simplify this even further using a ternary operator now that the else if condition is removed. Something like const targetQueries = defined(queries) ? queries.map(query => ...) : null;
Comment on lines
+220
to
+223
| for (const groupBy of queryToUpdate.groupBys) { | ||
| const value = row[groupBy]; | ||
| search.setFilterValues(groupBy, [value]); | ||
| } |
There was a problem hiding this comment.
minor nit, feels slightly more readable to me:
Suggested change
| for (const groupBy of queryToUpdate.groupBys) { | |
| const value = row[groupBy]; | |
| search.setFilterValues(groupBy, [value]); | |
| } | |
| queryToUpdate.groupBys.forEach(groupBy => { | |
| search.setFilterValues(groupBy, [row[groupBy]]); | |
| }); |
| index, | ||
| }: MultiQueryFieldProps) { | ||
| const queries = useReadQueriesFromLocation(); | ||
| const userQuery = queries[index]!.query; |
There was a problem hiding this comment.
Would it be safer to do something like this instead queries[index]?.query ?? ''? If there's a possibility that queries[index] is undefined somehow
Comment on lines
31
to
45
| const allFields: string[] = []; | ||
|
|
||
| for (const groupBy of groupBys) { | ||
| if (allFields.includes(groupBy)) { | ||
| continue; | ||
| } | ||
| allFields.push(groupBy); | ||
| } | ||
|
|
||
| for (const yAxis of yAxes) { | ||
| if (allFields.includes(yAxis)) { | ||
| continue; | ||
| } | ||
| allFields.push(yAxis); | ||
| } |
There was a problem hiding this comment.
If im understanding this correctly, I think you could use a Set here? So you don't have to check for existence and just drop everything into an allFields Set blindly. Unless the order matters, but there might be a datastructure for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State is currently persisted in the URL, but this is just for the first pass.
We'll need to store backend state eventually.
Needs follow up for: