Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav): Adjust labels in primary nav sidebar #84905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Feb 10, 2025

Adjusts labels in primary sidebar and adds them additionally to the top of secondary sidebar.

CleanShot 2025-02-10 at 16 12 13

@malwilley malwilley requested review from a team as code owners February 10, 2025 21:12
@malwilley malwilley removed request for a team February 10, 2025 21:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 10, 2025
@malwilley malwilley force-pushed the malwilley/feat/nav-no-icons branch from dd19eaf to c6dde55 Compare February 10, 2025 21:14
Copy link

codecov bot commented Feb 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8452 1 8451 3
View the top 1 failed test(s) by shortest run time
WidgetBuilder with events > Sort by selectors can update selectors values
Stack Traces | 0.726s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 2
Received array:  [<span data-test-id="label">count()</span>, <div class="css-1h9r4of-SingleValueLabel-overflowEllipsis e1qwfwjv0">count()</div>]
    at Object.<anonymous> (.../dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx:316:67)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

`;

const SidebarItemWrapper = styled('li')`
const SidebarItemWrapper = styled('li')<{isMobile: boolean}>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like you could do something to make isMobile css only here if you wanted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we actually had more CSS media queries before, but since we need isMobile in the context anyway I figured it would be cleaner to just use the JS completely. People won't be switching back and forth often so I figure it's probably a fine tradeoff

@malwilley malwilley changed the title feat(nav): Remove labels from primary nav sidebar feat(nav): Adjust labels in primary nav sidebar Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants