-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nav): Adjust labels in primary nav sidebar #84905
base: master
Are you sure you want to change the base?
Conversation
dd19eaf
to
c6dde55
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
`; | ||
|
||
const SidebarItemWrapper = styled('li')` | ||
const SidebarItemWrapper = styled('li')<{isMobile: boolean}>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like you could do something to make isMobile css only here if you wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we actually had more CSS media queries before, but since we need isMobile
in the context anyway I figured it would be cleaner to just use the JS completely. People won't be switching back and forth often so I figure it's probably a fine tradeoff
Adjusts labels in primary sidebar and adds them additionally to the top of secondary sidebar.