chore(issue-details): Show replay section off replay_id
#84393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JoshFerge
approved these changes
Jan 31, 2025
mrduncan
reviewed
Jan 31, 2025
scttcper
reviewed
Jan 31, 2025
| @@ -372,9 +372,7 @@ export function EventDetailsContent({ | |||
| </Fragment> | |||
| )} | |||
| <EventHydrationDiff event={event} group={group} /> | |||
| {issueTypeConfig.replays.enabled && ( | |||
There was a problem hiding this comment.
can we remove the issueTypeConfig.replays.enabled yet?
|
@scttcper as of now, we still use it to determine if we show the replays tab/section and for showing the replay count on the stream, so we can't delete it just yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the issue details page to show the replay section off the
replay_idinstead of the config. the config is still used in a few other places so it isn't being removed, butEventReplayalready checks for thereplay_idwhich is what we want to use to determine if we show replays