feat(ACI): Detector details PUT endpoint #84098

ceorourke · 2025-01-27T19:10:24Z

Create a PUT endpoint for detector details.

Addresses https://getsentry.atlassian.net/browse/ACI-114

codecov · 2025-01-27T19:28:40Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
23503	2	23501	290

View the top 2 failed test(s) by shortest run time

tests.sentry.workflow_engine.endpoints.test_project_detector_details.ProjectDetectorDetailsPutTest::test_update_add_data_condition

Stack Traces | 3.06s run time

#x1B[1m#x1B[.../workflow_engine/endpoints/test_project_detector_details.py#x1B[0m:213: in test_update_add_data_condition
    response = self.get_success_response(
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:688: in get_success_response
    assert_status_code(response, status_code)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:40: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (400, b'["SnubaQuery not found, can\'t update"]')#x1B[0m
#x1B[1m#x1B[31mE   assert 400 < 201#x1B[0m
#x1B[1m#x1B[31mE    +  where 400 = <Response status_code=400, "application/json">.status_code#x1B[0m

tests.sentry.workflow_engine.endpoints.test_project_detector_details.ProjectDetectorDetailsPutTest::test_update

Stack Traces | 3.53s run time

#x1B[1m#x1B[.../workflow_engine/endpoints/test_project_detector_details.py#x1B[0m:168: in test_update
    response = self.get_success_response(
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:688: in get_success_response
    assert_status_code(response, status_code)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:40: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (400, b'["SnubaQuery not found, can\'t update"]')#x1B[0m
#x1B[1m#x1B[31mE   assert 400 < 201#x1B[0m
#x1B[1m#x1B[31mE    +  where 400 = <Response status_code=400, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

src/sentry/incidents/endpoints/validators.py

ceorourke · 2025-02-13T21:37:13Z

src/sentry/workflow_engine/endpoints/project_detector_details.py

+        group_type = None
+        detector_group_type = detector.group_type
+
+        if detector_group_type:
+            group_type = request.data.get("detector_type") or detector_group_type.slug
+
+        if not group_type:
+            return Response(status=status.HTTP_400_BAD_REQUEST)


this is all for annoying typing reasons - if detector.group_type is None we can't get the slug

should we raise an exception if it's None in Detector.group_type so we can assume the return type is GroupType?

cathteng · 2025-02-13T23:31:34Z

src/sentry/workflow_engine/endpoints/project_detector_details.py

+        group_type = None
+        detector_group_type = detector.group_type
+
+        if detector_group_type:
+            group_type = request.data.get("detector_type") or detector_group_type.slug
+
+        if not group_type:
+            return Response(status=status.HTTP_400_BAD_REQUEST)


should we raise an exception if it's None in Detector.group_type so we can assume the return type is GroupType?

cathteng · 2025-02-13T23:35:53Z

src/sentry/workflow_engine/endpoints/validators/metric_alert_detector.py

+                raise serializers.ValidationError("DataConditionGroup not found, can't update")
+        # TODO make one if it doesn't exist and data is passed?
+
+        for data_condition in data_conditions:


would it be better to collect all the data conditions for the data condition group, delete them if they exist, and create new data conditions? we could use bulk_delete and bulk_create that way instead of one by one (fewer db hits) 🤔

cathteng · 2025-02-13T23:36:29Z

src/sentry/workflow_engine/endpoints/validators/metric_alert_detector.py

+    def update_data_source(self, instance, data_source):
+        try:
+            source_instance = DataSource.objects.get(detector=instance)
+        except DataSource.DoesNotExist:


does the data source need to be created if you add it to an existing detector?

cathteng · 2025-02-13T23:37:37Z

src/sentry/workflow_engine/endpoints/validators/metric_alert_detector.py

+    def update(self, instance, validated_data):
+        instance.name = validated_data.get("name", instance.name)
+        instance.type = validated_data.get("detector_type", instance.group_type).slug
+        condition_group = validated_data.pop("condition_group")


nit: is there a reason this is pop instead of get?

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 27, 2025

vercel bot deployed to Preview January 27, 2025 19:13 View deployment

vercel bot deployed to Preview January 27, 2025 19:31 View deployment

ceorourke commented Jan 27, 2025

View reviewed changes

src/sentry/incidents/endpoints/validators.py Outdated Show resolved Hide resolved

ceorourke commented Jan 27, 2025

View reviewed changes

src/sentry/incidents/endpoints/validators.py Outdated Show resolved Hide resolved

ceorourke marked this pull request as ready for review January 27, 2025 20:02

ceorourke requested review from a team as code owners January 27, 2025 20:02

vercel bot deployed to Preview January 27, 2025 20:02 View deployment

vercel bot deployed to Preview January 27, 2025 20:25 View deployment

ceorourke marked this pull request as draft January 27, 2025 20:42

ceorourke commented Jan 27, 2025

View reviewed changes

src/sentry/incidents/endpoints/validators.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 27, 2025 21:28 View deployment

vercel bot deployed to Preview January 27, 2025 22:15 View deployment

ceorourke force-pushed the ceorourke/detector-details-put branch from 394cdec to 4330776 Compare February 10, 2025 23:52

vercel bot deployed to Preview February 11, 2025 00:02 View deployment

ceorourke force-pushed the ceorourke/detector-details-put branch from 3137949 to ec4b7fe Compare February 11, 2025 01:18

vercel bot deployed to Preview February 11, 2025 01:25 View deployment

ceorourke force-pushed the ceorourke/detector-details-put branch from 22b212a to c9992a3 Compare February 12, 2025 00:48

vercel bot deployed to Preview February 12, 2025 00:52 View deployment

ceorourke force-pushed the ceorourke/detector-details-put branch from c9992a3 to 2ab2d9c Compare February 12, 2025 18:46

vercel bot deployed to Preview February 12, 2025 18:55 View deployment

ceorourke force-pushed the ceorourke/detector-details-put branch from 449820d to 12075bf Compare February 12, 2025 19:14

vercel bot deployed to Preview February 12, 2025 19:19 View deployment

ceorourke mentioned this pull request Feb 12, 2025

chore(ACI): Update validators to handle actual payload format #85110

Merged

ceorourke added 4 commits February 13, 2025 12:14

feat(aci): Add detector details PUT endpoint

d2b4918

update condition group

eb61228

handle updating condition group

03fd1be

update data source

0fc9389

ceorourke added 11 commits February 13, 2025 12:14

fix test, pass timewindow as minutes

846367b

fix subclass name

da1f20c

add test

d049955

I think I need this for CI

f1f1610

rebase and had to move stuff

4ac0497

plural data sources, update schema in test

e76b4ef

group_type -> detector_type

68da3a7

make a BaseDataConditionGroupValidator and update test payload

b55167a

update conditiongrouphandler, fix update_data_conditions

0eb8c25

fix a couple small things

78cdb5e

single data source, update after rebase

90424c8

ceorourke force-pushed the ceorourke/detector-details-put branch from 12075bf to 90424c8 Compare February 13, 2025 20:37

vercel bot deployed to Preview February 13, 2025 20:41 View deployment

small updates

99f1eba

ceorourke marked this pull request as ready for review February 13, 2025 20:42

vercel bot deployed to Preview February 13, 2025 20:46 View deployment

ceorourke added 2 commits February 13, 2025 13:21

make tests pass

dbedbd5

typing on endpoint

adf290f

vercel bot deployed to Preview February 13, 2025 21:24 View deployment

vercel bot deployed to Preview February 13, 2025 21:28 View deployment

ceorourke requested a review from saponifi3d February 13, 2025 21:36

ceorourke commented Feb 13, 2025

View reviewed changes

just snuba maybe?

b715dad

vercel bot deployed to Preview February 13, 2025 22:32 View deployment

cathteng reviewed Feb 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ACI): Detector details PUT endpoint #84098

feat(ACI): Detector details PUT endpoint #84098

ceorourke commented Jan 27, 2025

codecov bot commented Jan 27, 2025 •

edited

Loading

ceorourke Feb 13, 2025

cathteng Feb 13, 2025

cathteng Feb 13, 2025

cathteng Feb 13, 2025

cathteng Feb 13, 2025

cathteng Feb 13, 2025

feat(ACI): Detector details PUT endpoint #84098

Are you sure you want to change the base?

feat(ACI): Detector details PUT endpoint #84098

Conversation

ceorourke commented Jan 27, 2025

codecov bot commented Jan 27, 2025 • edited Loading

❌ 2 Tests Failed:

ceorourke Feb 13, 2025

Choose a reason for hiding this comment

cathteng Feb 13, 2025

Choose a reason for hiding this comment

cathteng Feb 13, 2025

Choose a reason for hiding this comment

cathteng Feb 13, 2025

Choose a reason for hiding this comment

cathteng Feb 13, 2025

Choose a reason for hiding this comment

cathteng Feb 13, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 27, 2025 •

edited

Loading