Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (aci milestone 3): dual update helpers for triggers and trigger actions #83943

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Jan 23, 2025

When updating an AlertRuleTrigger or AlertRuleTriggerAction, update the relevant rows in the ACI tables.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 40 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ry/workflow_engine/migration_helpers/alert_rule.py 11.11% 40 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83943      +/-   ##
==========================================
+ Coverage   87.62%   87.71%   +0.09%     
==========================================
  Files        9611     9569      -42     
  Lines      543583   552972    +9389     
  Branches    21333    21221     -112     
==========================================
+ Hits       476296   485032    +8736     
- Misses      66933    67573     +640     
- Partials      354      367      +13     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant