ref(explore): Use standard widget components #83845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 38.89kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
|
gggritso
force-pushed
the
ref/explore/use-standard-widgets
branch
from
3695d66 to
d437ca8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
DominikB2014
approved these changes
Feb 6, 2025
| @@ -58,7 +59,9 @@ export function getExploreUrl({ | |||
| ); | |||
| } | |||
|
|
|||
| export function combineConfidenceForSeries(series: Series[]): Confidence { | |||
| export function combineConfidenceForSeries( | |||
| series: Array<Pick<TimeseriesData, 'confidence'>> | |||
There was a problem hiding this comment.
Would it better to just do TimeseriesData[] here as the function implies that an entire series is the parameter?
Or is the Pick here for backwards compatibility with Series? If that's case we could also consider TimseriesData[] | Series[]
There was a problem hiding this comment.
Yep exactly, for backward compatibility. I could do the union too
There was a problem hiding this comment.
Union makes more sense to me, because with the Pick, I believe passing in any array of objects, where the object has confidence as a property, would work.
There was a problem hiding this comment.
And if we removed Series eventually, it's easier to find this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace current usage of
Chartfrom Insights with the standard visualization components from Dashboards.Closes https://github.com/getsentry/team-visibility/issues/20
Changes
Not too major!
Seriesobjects, now they pass aroundTimeseriesDataobjects. They're very similar, but they includemeta, which standard charts use to figure out the correct unitsTimeSeriesWidgetunit conversions #84264e.g.,
