Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(insights): add tooltips user misery and apdex #82880

Merged
merged 4 commits into from
Jan 6, 2025
Merged

feat(insights): add tooltips user misery and apdex #82880

merged 4 commits into from
Jan 6, 2025
+66 −24

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jan 3, 2025 •
edited
Loading

Adding tooltips for additional columns in insights pages.

User Misery table cells missing data:

Screenshot 2025-01-03 at 2 48 14 PM

Apdex column header

Screenshot 2025-01-03 at 2 48 03 PM

User misery column header

Screenshot 2025-01-03 at 2 47 54 PM

Frontend percentile headers

Note: this is just a small tweak, rather than the question mark the header text is underlined and has the tooltip (this is consistent with other insights modules and took up less horizontal space, which prevented user misery column from overflowing on small screens).

Screenshot 2025-01-03 at 2 47 39 PM

@bcoe bcoe requested review from a team as code owners January 3, 2025 19:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 3, 2025
@bcoe bcoe requested review from Zylphrex and DominikB2014 January 3, 2025 19:52
DominikB2014
DominikB2014 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits

static/app/utils/discover/fieldRenderers.tsx Outdated Show resolved Hide resolved
static/app/views/performance/table.tsx Outdated Show resolved Hide resolved
@bcoe bcoe force-pushed the describe-user-misery-apdex branch from c1dd58b to a2fd522 Compare January 3, 2025 20:22
@bcoe bcoe merged commit 726d151 into master Jan 6, 2025
42 checks passed
@bcoe bcoe deleted the describe-user-misery-apdex branch January 6, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikB2014 DominikB2014 DominikB2014 approved these changes

@Zylphrex Zylphrex Awaiting requested review from Zylphrex

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoe @DominikB2014