Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fork scope if custom scope is passed to startSpanManual #14901

Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 3, 2025

This PR follows up on #14900 and analogously forks an optionally passed custom scope to ensure the active span is only active inside the callback.

@Lms24 Lms24 changed the base branch from develop to lms/fix-core-restore-active-span-custom-scope January 3, 2025 13:43
@Lms24 Lms24 requested a review from mydea January 3, 2025 13:48
Copy link
Contributor

github-actions bot commented Jan 3, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.82 KB - -
@sentry/browser - with treeshaking flags 21.5 KB - -
@sentry/browser (incl. Tracing) 35.5 KB - -
@sentry/browser (incl. Tracing, Replay) 72.27 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.78 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.53 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.54 KB - -
@sentry/browser (incl. Feedback) 39.06 KB - -
@sentry/browser (incl. sendFeedback) 27.46 KB - -
@sentry/browser (incl. FeedbackAsync) 32.25 KB - -
@sentry/react 25.54 KB - -
@sentry/react (incl. Tracing) 38.26 KB - -
@sentry/vue 26.95 KB - -
@sentry/vue (incl. Tracing) 37.23 KB - -
@sentry/svelte 22.97 KB - -
CDN Bundle 24.14 KB - -
CDN Bundle (incl. Tracing) 35.82 KB -0.04% -14 B 🔽
CDN Bundle (incl. Tracing, Replay) 70.44 KB -0.03% -16 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 75.58 KB -0.03% -18 B 🔽
CDN Bundle - uncompressed 70.4 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.05 KB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.87 KB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.41 KB +0.01% +6 B 🔺
@sentry/nextjs (client) 38.38 KB - -
@sentry/sveltekit (client) 36.03 KB - -
@sentry/node 161.22 KB - -
@sentry/node - without tracing 97.04 KB +0.01% +4 B 🔺
@sentry/aws-serverless 126.91 KB +0.01% +1 B 🔺

View base workflow run

@Lms24 Lms24 self-assigned this Jan 3, 2025
@Lms24 Lms24 force-pushed the lms/fix-core-restore-active-span-custom-scope branch from c864c76 to 52b10a8 Compare January 10, 2025 10:58
Base automatically changed from lms/fix-core-restore-active-span-custom-scope to develop January 13, 2025 09:25
@Lms24 Lms24 force-pushed the lms/fix-core-startSpanManual-restore-active-span-custom-scope branch from bd3f4bc to 6f24b8f Compare January 13, 2025 11:39
@Lms24 Lms24 changed the title fix(core): Restore previously active span when passing a custom scope to startSpanManual fix(core): Fork scope if custom scope is passed to startSpanManual Jan 13, 2025
@Lms24 Lms24 marked this pull request as ready for review January 13, 2025 11:41
@Lms24 Lms24 force-pushed the lms/fix-core-startSpanManual-restore-active-span-custom-scope branch from 6f24b8f to d1f3d97 Compare January 15, 2025 14:03
@Lms24 Lms24 merged commit 559d3bf into develop Jan 17, 2025
156 checks passed
@Lms24 Lms24 deleted the lms/fix-core-startSpanManual-restore-active-span-custom-scope branch January 17, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants