-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(flags): support single-client tracking in OpenFeatureIntegration #14838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliu39
changed the title
ref(flags): abstract OpenFeatureHook away from setup and track a single OpenFeatureClient
ref(flags): remove OpenFeatureHook from exports/setup code
Dec 27, 2024
aliu39
changed the title
ref(flags): remove OpenFeatureHook from exports/setup code
ref(flags): remove OpenFeatureHook from exports and setup code
Dec 27, 2024
2 tasks
This reverts commit a35e2b9.
chargome
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aliu39
changed the title
ref(flags): remove OpenFeatureHook from exports and setup code
ref(flags): simplify OpenFeature setup code and unexport OpenFeatureHook
Jan 6, 2025
aliu39
changed the title
ref(flags): simplify OpenFeature setup code and unexport OpenFeatureHook
ref(flags): support single-client tracking in OpenFeatureIntegration
Jan 6, 2025
We have to rethink this since we decided to prioritize global tracking. The user's setup code could still be simplified, but prioritizing other FF work for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14645
By un-exporting the Hook, this will simplify setup for users.
The decision to track a single client is something we're doing across all FF integrations. From getsentry/sentry-python#3895:
Updated setup code can be seen at: https://github.com/getsentry/sentry-docs/pull/12222/files
Todo: