Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for image resources #7322

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Feb 11, 2025

What type of PR is this?

  • Bug Fix

Description

When MULTI_ORG is enabled, static/ URLs resolve to <org>/static/

Most resources already used an absolute path. This change fixes database icons and SVG illustrations.

How is this tested?

  • E2E Tests (Cypress)
  • Manually

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

24-01
fixed

eradman and others added 2 commits February 10, 2025 15:21
When MULTI_ORG is enabled, 'static/' resolves to '<org>/static/'
Copy link
Member

@gaecoli gaecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaecoli
Copy link
Member

gaecoli commented Feb 12, 2025

@eradman I also encountered the same problem, thank you! U can merge this PR to master!

@eradman eradman merged commit 925bb91 into getredash:master Feb 12, 2025
11 checks passed
@eradman eradman deleted the multi-org-static branch February 12, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants