Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: fail tests on purpose #6746

Closed
wants to merge 2 commits into from
Closed

Conversation

guidopetri
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Test PR, do not merge.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@guidopetri
Copy link
Contributor Author

As expected, the unit tests that should have failed passed. @AndrewChubatiuk @justinclift this is a problem, since it essentially means our CI is broken.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (320fddf) 63.41% compared to head (42e93ad) 63.41%.

❗ Current head 42e93ad differs from pull request most recent head c2cbd47. Consider uploading reports for the commit c2cbd47 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6746   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         162      162           
  Lines       13169    13169           
  Branches     1819     1819           
=======================================
  Hits         8351     8351           
  Misses       4522     4522           
  Partials      296      296           

@justinclift
Copy link
Member

Uh uh, that's not good. Any idea when it started?

@guidopetri
Copy link
Contributor Author

I'm pretty sure it was the pull request target PR.

@AndrewChubatiuk
Copy link
Contributor

@guidopetri updated checkout ref here

@guidopetri
Copy link
Contributor Author

Closing as the tests (correctly) fail now.

@guidopetri guidopetri closed this Feb 8, 2024
@justinclift justinclift deleted the gpetri/test-ci-broken branch February 8, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants