Revert example message for "Custom rule for hiding filter" #6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partialy reverts Hide filter components on shared pages getredash#6115 The "hide_filter" feature is incomplete, and the example text is confusing, adds clutter to the share dashboard dialog.
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6709 +/- ##
=======================================
Coverage 63.37% 63.38%
=======================================
Files 162 162
Lines 13170 13165 -5
Branches 1819 1817 -2
=======================================
- Hits 8347 8344 -3
Misses 4532 4532
+ Partials 291 289 -2 |
guidopetri
approved these changes
Jan 30, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
…#6709) Partialy reverts Hide filter components on shared pages getredash#6115 The "hide_filter" feature is incomplete, and the example text is confusing, adds clutter to the share dashboard dialog. Co-authored-by: github-actions <[email protected]> Co-authored-by: Guido Petri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rervert UI changes from #6115
What type of PR is this?
Description
The "hide_filter" feature is incomplete, and the example text is confusing, adds clutter to the share dashboard dialog.
How is this tested?