Issue 468 (#471)

  * removes bash-completion file from setup.py (fixes #468 )
  * do not execute 'rm -r' (dangerous!) if 'popper rm' cannot find a pipeline folder; throw an error instead.
  * init pipeline info message not shown.
  * bumps version up to 1.1.1
  * adds test to check that double `popper rm` doesn't do anything harmful

.gitignore

@@ -13,3 +13,4 @@ popper_status
 .cache
 popper_logs
 popper_status
+.pipeline_cache.yml

ci/test-rm.sh

@@ -7,6 +7,8 @@ init_test
 popper init mypipetwo
 popper rm mypipetwo
 
+! popper rm mypipetwo
+
 # test popper rm with paper
 popper init paper
 popper rm paper

cli/popper/__init__.py

@@ -1 +1 @@
-__version__ = '1.1.0'
+__version__ = '1.1.1'

cli/popper/commands/cmd_init.py

@@ -111,6 +111,9 @@ def cli(ctx, name, stages, envs, existing, infer_stages, timeout):
         relative_path=relative_path,
         timeout=timeout
     )
+    pu.info(
+        "Initialized pipeline '{}' at {}".format(name, relative_path),
+        fg='blue', bold=True)
 
 
 def initialize_repo(project_root):

cli/popper/commands/cmd_rm.py

@@ -14,15 +14,15 @@ def cli(ctx, pipeline):
     """
 
     project_root = pu.get_project_root()
-    pipeline_dir = project_root
-
     pipelines = pu.read_config()['pipelines']
 
     if pipeline in pipelines:
         path = pipelines[pipeline]['path']
         pipeline_dir = os.path.join(
-                pipeline_dir,
+                project_root,
                 path)
+    else:
+        pu.fail("Pipeline '{}' not in this project".format(pipeline))
 
     if os.path.isdir(pipeline_dir):
 
@@ -31,10 +31,10 @@ def cli(ctx, pipeline):
         popper_config = pu.read_config()
         del popper_config['pipelines'][pipeline]
 
-        pu.info("Pipeline {} removed successfully".format(pipeline),
-                fg="green")
+        pu.info("Pipeline '{}' removed successfully".format(pipeline),
+                fg="blue")
 
         pu.write_config(popper_config)
 
     else:
-        pu.fail("Pipeline {} doesn't exists".format(pipeline))
+        pu.fail("Path '{}' is not a folder".format(pipeline))

cli/setup.py

@@ -11,9 +11,6 @@
     author_email='[email protected]',
     url='http://falsifiable.us',
     description='Popper CLI tool to generate reproducible papers.',
-    data_files=[
-        ('/usr/local/etc/bash_completion.d', ['./extras/bash-completion.sh']),
-    ],
     packages=['popper', 'popper.commands'],
     include_package_data=True,
     install_requires=[