Add cache headers to responses #1390
Open
+235
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Feb 10, 2025
| @@ -58,6 +58,17 @@ module.exports = (container) => { | |||
| const cookieParser = require('cookie-parser'); | |||
| service.use(cookieParser()); | |||
|
|
|||
| service.use((req, res, next) => { | |||
| // TODO only set for safe methods? | |||
| // TODO only set for authenticated requests? | |||
There was a problem hiding this comment.
Are these todos for a reviewer to consider? Something you're still thinking about?
There was a problem hiding this comment.
Good question. I think I'd be happy deleting them both, but I'd be interested in a review of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#662
What has been done to verify that this works as intended?
Added tests.
Why is this the best possible solution? Were any other approaches considered?
It seems simple.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should prevent future caching surprises.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No? "cache" is not currently mentioned in docs/
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes