Allow s3 public read access property to be selected #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always use serverless-lift through redwoodjs. Thanks for the great package! When I created a static website using this package, I noticed that the publicReadAccess of the S3 bucket was set to true.
I think Lift is written on the premise of caching static websites in S3 bucket with CloudFront. However, when CloudFront is used as a CDN for a static website in an S3 bucket, it is not necessary to set S3 publicReadAccess to true.
In lift, even if publicReadAccess of S3 bucket is set to false using the
extensionsproperty, it is explicitly set to true in thesrc/constructs/aws/StaticWebsite.ts, so it could not be set using only theextensionsproperty.So I modified the program to allow the user to choose true or false for publicReadAccess.
At the same time, we felt it necessary to be able to change the indexPath property, so we implemented this as well.
If you don't mind, please check out this Pull Request!