-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle static filters and refactor component #1990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlago99
approved these changes
Jan 14, 2025
keellyp
force-pushed
the
lago-652-filters
branch
from
January 14, 2025 17:25
568a4aa
to
f51558e
Compare
keellyp
force-pushed
the
lago-652-filters
branch
from
January 15, 2025 09:34
f51558e
to
f44441e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to Analytics revamp feature
Description
This PR improves the
Filter
component by:filters
intoavailableFilters
propsstaticFilters
props to handle "default" filtersuseFilter
hook accessible for all components inside filter context providerQuickFilters
by creating a more generic function to build URL paramsHow to use it
Fixes LAGO-652