fix: custom agg json serializer (#1502)

* fix: remove json parse * fix: tests
getlago · May 16, 2024 · b6e5288 · b6e5288
1 parent 0e4538c
commit b6e5288
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/core/serializers/__tests__/serializePlanInput.test.ts b/src/core/serializers/__tests__/serializePlanInput.test.ts
@@ -786,14 +786,8 @@ describe('serializePlanInput()', () => {
               perTransactionMaxAmount: undefined,
               rate: '5',
               volumeRanges: undefined,
-              customProperties: {
-                ranges: [
-                  { from: 0, to: 100, thirdPart: '0.13', firstPart: '0.12' },
-                  { from: 101, to: 2000, thirdPart: '0.10', firstPart: '0.09' },
-                  { from: 2001, to: 5000, thirdPart: '0.08', firstPart: '0.07' },
-                  { from: 5001, to: null, thirdPart: '0.06', firstPart: '0.05' },
-                ],
-              },
+              customProperties:
+                '{"ranges":[{"from":0,"to":100,"thirdPart":"0.13","firstPart":"0.12"},{"from":101,"to":2000,"thirdPart":"0.10","firstPart":"0.09"},{"from":2001,"to":5000,"thirdPart":"0.08","firstPart":"0.07"},{"from":5001,"to":null,"thirdPart":"0.06","firstPart":"0.05"}]}',
             },
             taxCodes: [],
           },

diff --git a/src/core/serializers/serializePlanInput.ts b/src/core/serializers/serializePlanInput.ts
@@ -113,7 +113,7 @@ const serializeProperties = (properties: Properties, chargeModel: ChargeModelEnu
         }
       : { perTransactionMinAmount: undefined, perTransactionMaxAmount: undefined }),
     ...(chargeModel === ChargeModelEnum.Custom
-      ? { customProperties: JSON.parse(properties?.customProperties) }
+      ? { customProperties: properties?.customProperties }
       : { customProperties: undefined }),
   }
 }