Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for system view security checks #6932

Draft
wants to merge 2 commits into
base: develop-minor
Choose a base branch
from
Draft

Improvements for system view security checks #6932

wants to merge 2 commits into from

Conversation

distantnative
Copy link
Member

Description

Summary of changes

  • Some security checks won't run for local installations, in this case an info message is displayed
    Screenshot 2025-01-23 at 09 46 06

  • Debug warning is showing in info theme when on local, in negative theme when not local

  • Checking for LICENSE.md instead of composer.json

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative self-assigned this Jan 23, 2025
@distantnative distantnative linked an issue Jan 23, 2025 that may be closed by this pull request
Kirby Panel requests composer.json which triggers WAF #6878
Open
@distantnative distantnative force-pushed the enhancement/system-security-checks-local branch from ccb4e90 to 0097f02 Compare January 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@distantnative distantnative

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kirby Panel requests composer.json which triggers WAF
1 participant
@distantnative