Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: progress bar #78

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature: progress bar #78

wants to merge 3 commits into from

Conversation

PieturP
Copy link
Contributor

@PieturP PieturP commented Aug 3, 2021

Disable the 'Scan' button until all products are fetched. Show progress bar while loading.

@tareq1988 tareq1988 requested a review from xaviranik August 5, 2021 04:10
assets/src/frontend/components/Home.vue Outdated Show resolved Hide resolved
@xaviranik
Copy link
Contributor

Hello @PieturP, While testing your PR, We have noticed few points that need to be addressed:

  • You have implemented a progress bar on top of the product searching section, which in my opinion is not necessary as we already have a loading state and animation on the products section. From a UX perspective, having multiple loading progress for a single screen arises confusion for the users.
  • Current PR has an issue with product searching. If you search for a product in the search bar, no products are shown in the search dropdown.

Feedback:

  • You can use the current loading state and animation. Maybe use some CSS styling for toggling the disabled state for the 'Scan' button.
  • Look into the product searching issue.

I will be glad to help if you have any questions further.

@xaviranik xaviranik added Needs Author Reply Bug Something isn't working and removed Needs Testing This requires further testing Dev Review Done labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Author Reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants