Delete embedded causes corruption #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 16, 2020 12:05
The module line limit is preventing extra logic from being added to ensure that conflicting updates are not being created. I've chosen an arbitrary method for reducing the line count in the module. I'm open to suggestions if someone else has a better idea in mind.
The line limit for blocks is prevents additional specs from being added for Mongoid::History::Trackable. I've picked an arbitrary method of reducing the size of the block in order to get past that limit. I'm open to suggestions if someone has a better idea in mind.
After making the change to logic for incrementing the version number this spec started failing even though the behavior was actually correct. Though post.history_tracks returned an updated list of records, the call to #last continued to return the same "destroy" track, causing the comment to be created twice, instead of being recreated and then redestroyed. Addressing the last record by index appears to have resolved the problem.
cgriego
requested changes
Dec 16, 2020
|
@cgriego, That makes the PR much smaller, but it does beg the question, why have the constraint in the first place? :) |
cgriego
approved these changes
Dec 17, 2020
|
Superceded by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to this PR, as we've found more instances where setting the version is causing corrupted documents.
Additionally, in order to get around some line limits that are enforced on the repo, some code has been rearranged. A commit was created for each step in the process with an explanation of the motivation.