Avoid corrupting documents when tracking destroy #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The way I read this change is that we stop recording history records when deleting nested records, which isn't functionality we should remove. Is there an existing test showing that we still record these? |
|
This looks better. My final concern is that we're now recording history tracks with the same version when something is destroyed. The library expects these to be unique/sequential and it uses these for sorting and for the undo/redo functionality. I think we can appease that by ensuring we write an incremented value on destroy without incrementing the version field on the original document. |
cgriego
approved these changes
Nov 24, 2020
added 6 commits
November 25, 2020 10:42
If an embedded document has its version incremented, but an ancester is flagged for destroy and the root document is not, then this causes conflicts, which are written to the otherwise empty embedded document, leaving a corrupt document in storage. Note that this only happends with the parent document cascades callbacks.
dgknght
force-pushed
the
avoid-corrupt-documents
branch
from
4203f4e to
8880418
Compare
|
Moving to a new PR for the upstream repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an embedded document has its version incremented, but an ancester
is flagged for destroy and the root document is not, then this causes
conflicts, which are written to the otherwise empty embedded document,
leaving a corrupt document in storage.
Note that this only happens with the parent document cascades
callbacks.