Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiloader using Architectury #16

Closed

Conversation

SLimeyMC
Copy link

@SLimeyMC SLimeyMC commented May 3, 2024

Gradle Task

  • Folder structure
  • Root gradle
  • Common gradle
  • Fabric gradle
  • Forge gradle
  • Version catalog (?) (ditch version catalog for now)

Source Task

  • Networking
  • Entity
  • GUI
  • Config
  • EventHandler
  • Renderer
  • Fabric Platform
  • Forge Platform
  • Fabric Mod Compat
  • Forge Mod Compat

@SLimeyMC SLimeyMC marked this pull request as draft May 3, 2024 05:43
@getItemFromBlock
Copy link
Owner

Thanks for the PR, there is still quite a lot left to do but that should help towards a fabric version
I will take a closer look this weekend

@getItemFromBlock
Copy link
Owner

After a quick look there are some things that I don't understand completely, like why do we need to have the assets present in both the forge and fabric part, and not in the common part ?

@SLimeyMC
Copy link
Author

SLimeyMC commented May 5, 2024

Oh yeah, I dont know what I was thinking when separating it, I will work on putting it in common 😅

Anyway, I will be abandoning version catalog, it caused a problem with Gradle.
Also, do you want the Gradle to be written in Kotlin or not?

@getItemFromBlock
Copy link
Owner

getItemFromBlock commented May 5, 2024

I am not really familiar with Kotlin (hence why my mod is made in Java) so preferably not, but if it makes things easier to you then go for it
Actually I don't even know what would be the alternative, is it like the original build.gradle file ?

@SLimeyMC
Copy link
Author

SLimeyMC commented May 6, 2024

Nope, wildly different. Forge uses Forgegradle which has a lot of kinks IMO.

@getItemFromBlock
Copy link
Owner

Alright, then let's go with Kotlin

@getItemFromBlock
Copy link
Owner

Hi, any news on this ?
Tell me when you have finished all the gradle/initial setup part so that I can continue to work on this

@SLimeyMC
Copy link
Author

SLimeyMC commented May 14, 2024

Alright, I already smashed alot of bugs and it can build now. You may code peacefully

For context, I have separated the task into gradle and source tasks. Hopefully, the added task reflects what needs to be done

@getItemFromBlock
Copy link
Owner

Thanks a lot, this is some really good avancement for fabric compat
I will take a closer look when things get less busy for me

@Frankky001
Copy link

is the fabric port still being worked on? would be really nice if it releases before create aero. no pressure ofc 😊

@getItemFromBlock
Copy link
Owner

getItemFromBlock commented Jun 20, 2024

Yes, I plan to continue working on this soon
Right now I am taking some well deserved vacations, but don't worry I have not forgotten about this
Note that the Architectury port is not the only thing planned

@getItemFromBlock getItemFromBlock self-assigned this Jul 13, 2024
@getItemFromBlock getItemFromBlock marked this pull request as ready for review July 13, 2024 19:22
@getItemFromBlock getItemFromBlock mentioned this pull request Aug 15, 2024
@AnCarsenat
Copy link

Wow so nice ! Hope you get it down ! Great Work !
Also, I had an issue open with "fabric pls" im so sorry, I did not know
there was already a fork open ....

@getItemFromBlock
Copy link
Owner

Update on this, for the people that want fabric:
I pushed the some old changes that I should have pushed a while ago on a new branch "dev-1.18-architectury"
The mod does not build correctly. For some reasons gradle refuses to include the mod's code in the jar, and my lack of knowledge in gradle build script does not help
If someone want to take a look at the problem I would be very grateful

@SLimeyMC
Copy link
Author

SLimeyMC commented Jan 4, 2025

Turn it into a PR draft then, I'll look into it later. May as well link it here and close this one.

@getItemFromBlock getItemFromBlock marked this pull request as draft January 4, 2025 12:28
@SLimeyMC
Copy link
Author

SLimeyMC commented Jan 4, 2025

Sorry, let me rephrase. Make a new PR draft using the new branch you created, then post a comment linking to the new PR and close this PR.

@getItemFromBlock
Copy link
Owner

Oh mb

@getItemFromBlock
Copy link
Owner

getItemFromBlock commented Jan 5, 2025

Moved to #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants