avoid calling convex functions directly #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling convex functions -- queries/mutations/actions/httpactions -- directly, as if they were js functions. Instead, their
_handler
property is the js function, if it exists.This avoids a new console.warn which was added to "convex/server" which happens if you call a registered query/mutation/action/httpaction directly.
I added some types, but i'm not sure if this makes it actually safer. the main benefit was not needing casts to make the PublicHttpAction type flow through from
router.lookup
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.