Make isAuthenticated in middleware fail more loudly. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dowski
reviewed
Dec 18, 2024
CHANGELOG.md
Outdated
| returned false in the case of a Convex backend that didn't expose an endpoint | ||
| called `auth:isAuthenticated`, now it throws an error. This should help people | ||
| with the migration required for 0.0.76. | ||
|
|
||
| ## 0.0.78 |
There was a problem hiding this comment.
Technically this is unreleased too, I think - I just speculatively added the next version # when I updated this file earlier.
dowski
approved these changes
Dec 18, 2024
dowski
reviewed
Dec 18, 2024
src/nextjs/server/index.tsx
Outdated
| "Server Error: could not find api.auth.isAuthenticated. convex-auth 0.0.76 introduced a new export in convex/auth.ts. Add `isAuthenticated` to the list of functions returned from convexAuth(). See convex-auth changelog for more https://github.com/get-convex/convex-auth/blob/main/CHANGELOG.md", | ||
| ); | ||
| } | ||
| throw e; |
There was a problem hiding this comment.
I think you need to return false here. Otherwise errors like sending an invalid JWT to the Convex backend will also throw (which is why that one test is failing, I think).
There was a problem hiding this comment.
Hooray for tests!
There was a problem hiding this comment.
Ah for the token expired and invalid token cases, got it. Maybe we can pick those out too, for now I'll log whatever error it is.
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Next.js middleware function
isAuthenticatedfail more loudly. Previously it returned false in the case of a Convex backend that didn't expose an endpoint calledauth:isAuthenticated, now it throws an error. This should help people with the migration required for 0.0.76.