Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple tweaks to allow a CUSTOM_AUTH_SITE_URL #142

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

dowski
Copy link
Collaborator

@dowski dowski commented Dec 17, 2024

This will allow a custom domain for signin and callback URLs. OAuth providers like Google (which show the domain) will use this instead of showing happy-animal-123.convex.site in the OAuth consent screen.

This should help to resolve #53.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This will be for the signin and callback URLs.
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
convex-auth-docs ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:56pm

Copy link
Contributor

@thomasballinger thomasballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's slick! If there's any confusing or possible mismatch issue we can anticipate interested in addressing it next, this PR lgtm though

@dowski dowski merged commit 754fdbc into get-convex:main Dec 17, 2024
3 checks passed
@dowski dowski deleted the custom-domain-support branch December 17, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom redirect domains
2 participants