Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e tests in CI with latest prebuilt backend binary #131

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Run e2e tests in CI with latest prebuilt backend binary #131

merged 8 commits into from
Dec 4, 2024

Conversation

thomasballinger
Copy link
Contributor

@thomasballinger thomasballinger commented Dec 4, 2024 •
edited
Loading

Getting the old path of an open source backend directory wasn't temporarily broken so I hooked this up to prebuilt binaries.

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
convex-auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:25pm

@thomasballinger
Run test with latest prebuilt backend binary.
578cea3 
Getting the old path of a backend directory was too much trouble, we
need convex-backend changes to make this work.
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 4, 2024 •
edited
Loading 

npm i https://pkg.pr.new/get-convex/convex-auth/@convex-dev/auth@131

commit: df70184

@thomasballinger
Copy link
Contributor Author

thomasballinger commented Dec 4, 2024 •
edited
Loading

I ran into issues with using with a convex monorepo or a convex-backend repo for testing:

  • with a convex/ repo, run-local-backend already has a --port flag so runs on 8000, can't be overridden with another --port flag
  • with a convex-backend repo, run-local-backend seems broken because the simulation project isn't present. This is temporary

@thomasballinger thomasballinger changed the title Run test with latest prebuilt backend binary. Run test with latest prebuilt backend binary Dec 4, 2024
@thomasballinger thomasballinger changed the title Run test with latest prebuilt backend binary Run e2e tests in CI with latest prebuilt backend binary Dec 4, 2024
dowski
dowski approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dowski dowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice change.

test-nextjs/e2e-tests/README.md
@@ -15,7 +19,7 @@ you can skip to running the test command at the end.
CONVEX_LOCAL_BACKEND_PATH=/path/to/your/convex-backend npm run test
```

## The manual way
## The most manual way
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, love it!

test-nextjs/playwright.config.ts Outdated Show resolved Hide resolved
@thomasballinger thomasballinger merged commit c6dc7dd into main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dowski dowski dowski approved these changes

@sshader sshader Awaiting requested review from sshader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasballinger @dowski