Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing release version to artifacts filename #186

Merged
merged 1 commit into from
Jan 11, 2024
Merged

added missing release version to artifacts filename #186

merged 1 commit into from
Jan 11, 2024

Conversation

shakahl
Copy link
Contributor

@shakahl shakahl commented Jan 11, 2024 •
edited
Loading

Task

  • Need to add version field to artifacts filename because the new template did not constained it.

@shakahl shakahl requested a review from a team as a code owner January 11, 2024 13:49
@shakahl shakahl self-assigned this Jan 11, 2024
@shakahl shakahl requested review from jppakalapati and psi January 11, 2024 13:50
jppakalapati
jppakalapati approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jppakalapati jppakalapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shakahl shakahl merged commit 55c253d into master Jan 11, 2024
1 check passed
@shakahl shakahl deleted the bug/fix-missing-version-number-in-release-artifacts branch January 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jppakalapati jppakalapati jppakalapati approved these changes

@psi psi Awaiting requested review from psi

Assignees

@shakahl shakahl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakahl @jppakalapati