Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the DryDep collection to the benchmark summary table, and DryDepVel plots to 1-mon cloud benchmarks #336

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add the DryDep collection to the benchmark summary table, and DryDepVel plots to 1-mon cloud benchmarks #336

merged 2 commits into from
Aug 29, 2024

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

The GEOS-Chem DryDep collection was restored to all fullchem benchmark simulations in geoschem/geos-chem#2144. This is the corresponding GCPy PR, which includes

Expected changes

The DryDep collection will be included in this table:

################################################################################
### Benchmark summary table                                                  ###
###                                                                          ###
### Ref = GCC_ref                                                            ###
### Dev = GCC_dev                                                            ###
################################################################################

-------------------------------------------------------------------------------
AerosolMass: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
Aerosols: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
DryDep: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
Emissions: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
JValues: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
Metrics: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
SpeciesConc: GCC_dev is identical to GCC_ref

-------------------------------------------------------------------------------
StateMet: GCC_dev is identical to GCC_ref

If the dry deposition velocities differ, you will see output similar to this:

-------------------------------------------------------------------------------
DryDep: GCC_dev differs from GCC_ref

  Diagnostics that differ
    DryDepVel_ACET
    DryDepVel_ACTA
    DryDepVel_AERI
    DryDepVel_ALD2
    DryDepVel_AONITA
    DryDepVel_AROMP4
    DryDepVel_AROMP5
    DryDepVel_ASOA1
    DryDepVel_ASOA2
    DryDepVel_ASOA3
    DryDepVel_ASOAN
    DryDepVel_ASOG1
    ... and 323 others

NOTE: We should merge this once we have both Ref and Dev cloud benchmarks with dry deposition diagnostics turned on. This should be at 14.5.0-alpha.9.

Reference(s)

N/A

Related Github Issue

@yantosca
Add DryDep collection to benchmark summary table
6a7518b 
gcpy/benchmark/run_benchmark.py
- Add the DryDep collection to the benchmark summary table.  The DryDep
  collection was restored to all 1-hr and 1-mon fullchem benchmark
  simulations.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Create drydep plots in 1-month cloud benchmarks
b20d99e 
gcpy/benchmark/cloud/template.1mo_benchmark
- Now set "plot_drydep: true".  This will generate benchmark surface
  comparison plots of dry deposition velocity for selected species.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output labels Aug 28, 2024
@yantosca yantosca added this to the 1.5.1 milestone Aug 28, 2024
@yantosca yantosca requested a review from msulprizio August 28, 2024 17:20
@yantosca yantosca self-assigned this Aug 28, 2024
@yantosca yantosca changed the title Add the DryDep collection to the benchmark summary table Add the DryDep collection to the benchmark summary table, and DryDepVel plots to 1-hr cloud benchmarks Aug 28, 2024
@yantosca yantosca changed the base branch from main to dev August 28, 2024 17:21
@yantosca yantosca changed the title Add the DryDep collection to the benchmark summary table, and DryDepVel plots to 1-hr cloud benchmarks Add the DryDep collection to the benchmark summary table, and DryDepVel plots to 1-mon cloud benchmarks Aug 29, 2024
@yantosca yantosca merged commit 9e66715 into dev Aug 29, 2024
14 checks passed
@yantosca yantosca deleted the feature/add-drydep-to-bmk-summary branch September 5, 2024 21:36
@yantosca yantosca modified the milestones: 1.5.1, 1.6.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msulprizio msulprizio msulprizio approved these changes

Assignees

@yantosca yantosca

Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yantosca @msulprizio