-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows/ci.yml: run 'cargo valgrind test --lib' #472
Conversation
a0c3120
to
290987f
Compare
I expected this to be slower, but 30 seconds isn't bad at all. |
I'm thinking it might be a good idea to run this in the 3.8 container, since LTS might not have some of the APIs (like MD) we've implemented. |
09814dc
to
53c27a5
Compare
I've added a commit for that. Ok, it detects a leak in gdal::raster::mdarray::MDArray::read_into_slice (). I need to figure out how to build georust/gdal against my custom GDAL build rather than the 3.0.4 that comes with my Ubuntu version |
Great, we can disable it for now. https://github.com/georust/gdal/tree/master/gdal-sys#build might help with linking. |
Not sure if that, but we might be leaking the data type in the error case at https://github.com/georust/gdal/blob/master/src/raster/mdarray.rs#L166. |
ok, the leak in read_into_slice() is fixed now, but there's a "system leak" related to threads & TLS, that is IMHO a false positive. But I can't find an option to specify a Valgrind suppression file to cargo valgrind. I guess we need to skip 3.8.1 testing for now |
Yeah, let's disable it. I'll merge this in the morning. |
340ef60
to
a562101
Compare
I've dropped the 3.8.1 related commit |
Funny, I don't get the TLS leak on my system (Gedora 39, GDAL 3.7.3). I think we can pass in a suppressions file with |
CHANGES.md
if knowledge of this change could be valuable to users.