-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse xml metadata to identify ogc layers #12
Conversation
backend/maelstro/metadata/meta.py
Outdated
|
||
|
||
class Meta: | ||
def __init__(self, zipfile: bytes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make 2 init class depending on which format we use (from xml for from mef zip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, good idea.
there will be more functionalities with the zip file, but there is also common stuff like layer parsing
backend/maelstro/metadata/meta.py
Outdated
dr = DictReader(StringIO(zip_properties), delimiter=";") | ||
self.properties = next(dr) | ||
|
||
self.xml_bytes = zf.read(f"{self.properties['uuid']}/metadata/metadata.xml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default metadata can be found at this (static path), additionnally, the othe format may be added as a suffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it is depending on the default format, for example
is there is only iso19139 it will have only one file name medatada.xml
but if there is both iso 19139 and 19115 there will be two files matedata-iso19139 and metadata (from my sample) but it might be the opposite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I understand, the default schema is defined in the schema column of index.csv. The metadata corresponding to this default format will be called metadata.xml, there may be additional xml files with suffix in other formats and can be ignorer.
But we know, that metadata.xml is in the format given by index.csv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should ignore other format if we want to make a real copy
but yes true the default is in index.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything will be copied, the default format is just used for parsing the layers since we can be sure that it exists
backend/maelstro/metadata/meta.py
Outdated
|
||
self.xml_bytes = zf.read(f"{self.properties['uuid']}/metadata/metadata.xml") | ||
|
||
schema = self.properties.get("schema", "iso19139") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema is not "static"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is read from the csv file, which should have a 'schema' column/ Do you think this is not reliable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess yes it is reliable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -32,6 +32,8 @@ services: | |||
volumes: | |||
- ./backend:/app | |||
- georchestra_datadir:/etc/georchestra | |||
environment: | |||
- LOCAL_LOGIN=admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see it use anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I think this goes with the other PR
No description provided.