Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use header config file #32

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat: use header config file #32

merged 5 commits into from
Jan 23, 2025

Conversation

landryb
Copy link
Member

@landryb landryb commented Jan 3, 2025

cf georchestra/header#25, mostly cut&paste from georchestra/geoserver#38 and others, untested yet.

@landryb landryb requested a review from f-necas January 3, 2025 13:23
@landryb landryb mentioned this pull request Jan 3, 2025
Merged
12 tasks
@landryb landryb force-pushed the feat/header-config-file branch from de16b24 to 15460c6 Compare January 3, 2025 13:29
@landryb
Copy link
Member Author

landryb commented Jan 3, 2025

works here in my limited testing, with the following defined in default.properties:

headerHeight=80
headerScript=/dist/header.js
headerConfigFile=/dist/config.json
georchestraStylesheet=/dist/jdev20241231.css

f-necas
f-necas requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs attributes back, remove style attribute and we're good !

@f-necas f-necas merged commit 1ed207b into georchestra:master Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-necas f-necas f-necas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@landryb @f-necas