Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Boot 3.3.0 and Java 21, enabled virtual threads #34

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

groldan
Copy link
Member

@groldan groldan commented Jun 18, 2024

Upgrade to latest spring boot version and enable virtual threads for request processing.

Upgrade to latest spring boot version and enable virtual threads for
request processing.
@pmauduit
Copy link
Member

pmauduit commented Jun 18, 2024

LGTM (by the way, was it to give a shot to virtual threads onto a random spring boot app ? :-))

(also cf https://spring.io/blog/2022/10/11/embracing-virtual-threads for the motivation)

@groldan
Copy link
Member Author

groldan commented Jun 19, 2024

LGTM (by the way, was it to give a shot to virtual threads onto a random spring boot app ? :-))

(also cf https://spring.io/blog/2022/10/11/embracing-virtual-threads for the motivation)

I think it's a good project to take advantage of better resource usage.

@groldan groldan merged commit d9455c0 into main Jun 19, 2024
1 check passed
@groldan groldan deleted the java21_spring_upgrade branch June 19, 2024 11:54
pmauduit added a commit that referenced this pull request Jun 25, 2024
@pmauduit
Copy link
Member

pmauduit commented Jun 25, 2024

Note: if trying to profile when virtual threads enabled, you can stumble upon the following bug in visualvm: oracle/visualvm#549

but just setting spring.thread.virtual.enabled to false fixes it and sounds acceptable for such debugging endeavour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants