-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Random Latent Clique Lifting from Graphs to Simplicial Complexes (icml24-63) #139
Draft
luisfpereira
wants to merge
78
commits into
geometric-intelligence:main
Choose a base branch
from
luisfpereira:icml2024-pr63
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
A Random Latent Clique Lifting from Graphs to Simplicial Complexes (icml24-63) #139
luisfpereira
wants to merge
78
commits into
geometric-intelligence:main
from
luisfpereira:icml2024-pr63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Transform pipeline
…st-submission Wrapup first submission
Replaced default README with model explanation.
…to directly use nxGraph
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in pyt-team/challenge-icml-2024#63.
Points to consider:
first use of
ComposedLiftingMap
-> code differs more from original than in other related PRsfirst use of a
graph2graph
liftingtests are not testing much
original PR message added as modules docstring (it is somehow distributed between the two new lifting files; small inconsistencies are likely)
tutorial disregarded
NB: need to merge #116 first