Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Random Latent Clique Lifting from Graphs to Simplicial Complexes (icml24-63) #139

Draft
wants to merge 78 commits into
base: main
Choose a base branch
from

Conversation

luisfpereira
Copy link
Collaborator

This PR brings in pyt-team/challenge-icml-2024#63.

Points to consider:

  • first use of ComposedLiftingMap -> code differs more from original than in other related PRs

  • first use of a graph2graph lifting

  • tests are not testing much

  • original PR message added as modules docstring (it is somehow distributed between the two new lifting files; small inconsistencies are likely)

  • tutorial disregarded

NB: need to merge #116 first

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 78.00000% with 154 lines in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (99de7cb) to head (a3be6a4).

Files with missing lines Patch % Lines
...k/transforms/liftings/graph2graph/latent_clique.py 57.14% 132 Missing ⚠️
topobenchmark/data/utils/adapters.py 89.58% 10 Missing ⚠️
topobenchmark/transforms/liftings/base.py 94.00% 3 Missing ⚠️
topobenchmark/data/utils/domain.py 94.73% 2 Missing ⚠️
topobenchmark/transforms/feature_liftings/set.py 90.00% 2 Missing ⚠️
topobenchmark/transforms/data_transform.py 96.66% 1 Missing ⚠️
...hmark/transforms/feature_liftings/concatenation.py 94.73% 1 Missing ⚠️
...obenchmark/transforms/feature_liftings/identity.py 75.00% 1 Missing ⚠️
...mark/transforms/feature_liftings/projection_sum.py 87.50% 1 Missing ⚠️
...hmark/transforms/liftings/graph2hypergraph/khop.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   91.00%   88.36%   -2.64%     
==========================================
  Files         129      132       +3     
  Lines        3670     3998     +328     
==========================================
+ Hits         3340     3533     +193     
- Misses        330      465     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants