Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnD Lifting (Graph to Simplicial Complex) (icml24-11) #137

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

luisfpereira
Copy link
Collaborator

This PR brings in pyt-team/challenge-icml-2024#11.

Points to consider:

  • maybe add test for node features?

  • original PR message added as module docstring

  • tutorial disregarded

NB: need to merge #116 first

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 94.61358% with 23 lines in your changes missing coverage. Please review.

Project coverage is 91.03%. Comparing base (99de7cb) to head (12d6794).

Files with missing lines Patch % Lines
topobenchmark/data/utils/adapters.py 89.58% 10 Missing ⚠️
topobenchmark/transforms/liftings/base.py 93.02% 3 Missing ⚠️
topobenchmark/data/utils/domain.py 94.73% 2 Missing ⚠️
topobenchmark/transforms/feature_liftings/set.py 90.00% 2 Missing ⚠️
topobenchmark/transforms/data_transform.py 96.66% 1 Missing ⚠️
...hmark/transforms/feature_liftings/concatenation.py 94.73% 1 Missing ⚠️
...obenchmark/transforms/feature_liftings/identity.py 75.00% 1 Missing ⚠️
...mark/transforms/feature_liftings/projection_sum.py 87.50% 1 Missing ⚠️
...hmark/transforms/liftings/graph2hypergraph/khop.py 88.88% 1 Missing ⚠️
...ransforms/liftings/graph2simplicial/dnd_lifting.py 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   91.00%   91.03%   +0.02%     
==========================================
  Files         129      130       +1     
  Lines        3670     3725      +55     
==========================================
+ Hits         3340     3391      +51     
- Misses        330      334       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luisfpereira luisfpereira changed the title DnD Lifting (Graph to Simplicial Complex) DnD Lifting (Graph to Simplicial Complex) (icml24-11) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants