Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(golint): put the files inside cmd/foo and add more go style #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mishudark
Copy link

Hi, I add a more go style project style (put the executable files inside cmd/foo)

@geohot
Copy link
Owner

geohot commented Dec 26, 2016

Ewww are those tabs?

But I appreciate your contribution to me learning Go, and I will study proper file placement tomorrow.

@geohot
Copy link
Owner

geohot commented Dec 26, 2016

Closed because tabs make me cry.

@geohot geohot closed this Dec 26, 2016
@mishudark
Copy link
Author

Hi, according the Go docs, the indent should be tabs, go has gofmt tool that help to auto format the code

https://golang.org/cmd/gofmt/

Gofmt formats Go programs. It uses tabs (width = 8) for indentation and blanks for alignment

@geohot geohot reopened this Dec 26, 2016
@geohot
Copy link
Owner

geohot commented Dec 26, 2016

So I know this now, but this makes me sad. Tabs make me sad, and knowing that go supports tabs makes me think of them like <insert political candidate you don't like here>. If tabs become our president I'm moving to Canada.

Also, width = 8 is absurd. Google C++ is 2 space and that is god tier like Pikachu https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs

@mishudark
Copy link
Author

I felt the same at the beginning, but after a few days and seeing the power of go and their community I chose to stay in the same country

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants