SimulatorAccess for StokesMatrixFree #6247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that always bothered me about the StokesMatrixFree class was how liberally it used the pointer to simulator to access information it could have gotten from SimulatorAccess instead. This PR is a first step towards disentangling StokesMatrixFree from Simulator internals. Ultimately, I am thinking of making the solvers their independent plugin system as well. I am not sure if we fully get there, but at least with the current changes the code also looks more like a normal plugin.
This PR:
StokesMatrixFree
fromSimulatorAccess
andPlugins::InterfaceBase
, to give it read access via SimulatorAccess and align its functions more with how all other plugins look like.StokesMatrixFree
to the order of functions we usually use (costructor -> initialize_simulator -> parse_parameters -> initialize).sim. ...
) with simulator_acces (this->get_...
)Ideally, no functionality should change.