Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: do not use 20.04 #6232

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Feb 12, 2025

part of #6231

@tjhei
Copy link
Member Author

tjhei commented Feb 12, 2025

I opted to do one at 24.04 (shipping 9.5) and one at 22.04. We might also think about updating to 9.6: maybe just the no-unity build or something?

@tjhei
Copy link
Member Author

tjhei commented Feb 12, 2025

I am running into biber warnings breaking the documentation build on 22.04:
Use of uninitialized value $opt in hash element at /usr/share/perl5/Biber/Config.pm line 967.

@gassmoeller
Copy link
Member

/rebuild

@gassmoeller
Copy link
Member

let us know if you need testing and/or a review

I think running one tester on 22.04 and one on 24.04 is a good idea. Switching to deal.II 9.6 was on my list of things to do any time before this years hackathon, so we can remove some compatibility code as starter projects. So yes, moving the testers to 9.6 also makes sense.

@tjhei
Copy link
Member Author

tjhei commented Feb 14, 2025

I think this works and is good to go. We can change deal.II versions separately.

Are you saying we should require 9.6 soon?

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

I was saying we should switch the reference tester over to 9.6 soon, and then require 9.6 some time before the hackathon. I can set this up in the coming weeks.

@gassmoeller gassmoeller merged commit 551530e into geodynamics:main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants