add clang/clang-tidy Github-Actions workflow #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tjhei
commented
Jun 14, 2024
tjhei
commented
- add action to compile with Clang and run clang-tidy
- This action takes close to 2hr to complete, so disable for PRs for now
gassmoeller
approved these changes
Jun 14, 2024
source/postprocess/particles.cc
Outdated
| @@ -453,7 +453,7 @@ namespace aspect | |||
|
|
|||
| // ...then continue with writing our own data. | |||
| background_thread | |||
| = std::thread([ my_filename = std::move(filename), | |||
| = std::thread([ my_filename = filename, // filename is const, so we can not move from it | |||
There was a problem hiding this comment.
I guess you'll have to rebase after #5907 is merged.
tjhei
force-pushed
the
clang-tidy-workflow
branch
from
1254d24 to
c22406e
Compare
gassmoeller
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.