-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a signal before building patches for visualization output #5787
Conversation
template <int dim> | ||
void pre_data_out_build_patches (DataOut<dim> &) | ||
{ | ||
std::cout << "\npre_data_out_build_patches:\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this output is not triggered or am I wrong? Are you generating graphical output in every step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | ||
* A signal that is called before the build_patches() function is called during | ||
* the creation of the visualization output. This signal | ||
* allows for registering functions that take a DataOut object and can for example | ||
* be used to select only certain cells of the mesh to be built into patches through | ||
* calling the DataOut member function set_cell_selection(). | ||
*/ | ||
boost::signals2::signal<void (DataOut<dim> &)> pre_data_out_build_patches; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one way. I assume you want to use this to let the called function attach itself to the DataOut? Why not have a signal that returns a function object selecting individual cells that can then directly be attached to DoFHandler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As just discussed, we tried to keep the signal as general as possible as other things could be done with DataOut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot: Would you mind reducing the number of commits?
6bae5e7
to
4afb125
Compare
Add a signal that can modify data_out during the creation of visualization output. It can be used to for example select only part of the domain to be outputted.
For all pull requests:
For new features/models or changes of existing features: