Create a Cookbook for the Tian Parameterization Reactive Fluid Transport Model #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
4 times, most recently
from
3fe7b6f to
e14f4a8
Compare
danieldouglas92
changed the title
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
7d53a03 to
c952f26
Compare
naliboff
reviewed
Jun 4, 2024
There was a problem hiding this comment.
@danieldouglas92 - Thanks for this contribution, really exciting to see the results of all these pieces coming together. An initial round of comments on the PRM file is below.
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
naliboff
reviewed
Jun 4, 2024
There was a problem hiding this comment.
@danieldouglas92 - A few more comments to address, more to come later on. Overall the structure and content is in pretty good shape. The figure looks great, exciting results!
One of the main things that I think should be updated is a much more detailed description of the choices for both physical and numerical, given that these models are highly nonlinear and small variations in some parameters can lead to significant variations in model behavior. In general, I think it will be easiest to do this in the PRM file and keep the cookbook text more focused on what is being observed.
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/schematic-diagram.png
Outdated
Show resolved
Hide resolved
.../tian_parameterization_kinematic_slab/single_phase_tian_parameterization_kinenmatic_slab.prm
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
jdannberg
reviewed
Jun 4, 2024
cookbooks/tian_parameterization_kinematic_slab/doc/schematic_diagram.png
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...parameterization_kinematic_slab/uncoupled-two-phase-tian-parameterization-kinematic-slab.prm
Show resolved
Hide resolved
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
3 times, most recently
from
e4fd9d4 to
c5c9176
Compare
naliboff
reviewed
Jun 5, 2024
There was a problem hiding this comment.
@danieldouglas92 - Thanks for all of the changes so far, and a few more comments below. I think after this the cookbook should be ready or nearly ready from my side.
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Outdated
Show resolved
Hide resolved
cookbooks/tian_parameterization_kinematic_slab/doc/tian_parameterization_kinematic_slab.md
Show resolved
Hide resolved
...parameterization_kinematic_slab/uncoupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
71e33ec to
d35377a
Compare
jdannberg
reviewed
Jun 5, 2024
tests/uncoupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
tests/uncoupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
tests/coupled_two_phase_tian_parameterization_kinematic_slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
d35377a to
94c6746
Compare
naliboff
requested changes
Jun 5, 2024
There was a problem hiding this comment.
@danieldouglas92 - Just a few more minor comments, and then this is ready to merge from my side!
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Outdated
Show resolved
Hide resolved
...n_parameterization_kinematic_slab/coupled-two-phase-tian-parameterization-kinematic-slab.prm
Show resolved
Hide resolved
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
94c6746 to
4d9f83a
Compare
naliboff
approved these changes
Jun 5, 2024
jdannberg
approved these changes
Jun 5, 2024
|
/rebuild |
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
4d9f83a to
3d91168
Compare
danieldouglas92
force-pushed
the
tian_parameterization_kinematic_slab
branch
from
3d91168 to
58a1b62
Compare
tjhei
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a cookbook of simple subduction that demonstrates how the Tian approximation is used to simulate hydration/dehydration reactions between a solid and fluid phase. This cookbook investigates the upper 20 km of a slab that is comprised of 3 hydrated lithologies: sediment, MORB, and gabbro that subducts through a hot peridotite mantle. The slab enters the model from the left through fixed composition and temperature boundary conditions. It moves at 5 cm/yr due to kinematic boundary conditions on all sides, and heats up with time causing the dehydration of the lithologies within the slab. As a result, the overlying peridotite mantle is partially hydrated. A slab dip of 45 degrees is achieved by orienting the gravity vector at an angle of 45 degrees from vertical (see schematic diagram).
One input file models an uncoupled system, where the solid phase is unaffected by the fluid phase. The second input file models a coupled system, where the solid and fluid phases directly impact each other.