Try to recover from logging errors when closing application

Closes: quarkusio#45650
geoand · Jan 20, 2025 · ef1aaaa · ef1aaaa
1 parent 34eb48e
commit ef1aaaa
Showing 1 changed file with 23 additions and 2 deletions.
diff --git a/...ts/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java b/...ts/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java
@@ -146,15 +146,36 @@ public final void close() throws SecurityException {
         synchronized (this) {
             if (!logRecords.isEmpty()) {
                 Formatter formatter = getFormatter();
+                Formatter defaultFormatter = new PatternFormatter("%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c] (%t) %s%e%n");
+                boolean usingDefaultFormatter = false;
                 if (formatter == null) {
-                    formatter = new PatternFormatter("%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c] (%t) %s%e%n");
+                    usingDefaultFormatter = true;
+                    formatter = defaultFormatter;
                 }
                 StandardOutputStreams.printError("The DelayedHandler was closed before any children handlers were " +
                         "configured. Messages will be written to stderr.");
                 // Always attempt to drain the queue
                 ExtLogRecord record;
+                Exception formattingException = null;
                 while ((record = logRecords.pollFirst()) != null) {
-                    StandardOutputStreams.printError(formatter.format(record));
+                    String value = null;
+                    try {
+                        value = formatter.format(record);
+                    } catch (Exception e) {
+                        if (!usingDefaultFormatter) {
+                            // try once more using the default formatter
+                            value = defaultFormatter.format(record);
+                        } else {
+                            formattingException = e;
+                        }
+                    }
+                    if (value != null) {
+                        StandardOutputStreams.printError(value);
+                    }
+                }
+                if (formattingException != null) {
+                    // let's just log the last formatting exception as there is not much more we can do
+                    formattingException.printStackTrace();
                 }
             }
         }