Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fSCA and SNOTEL #6

Closed
wants to merge 14 commits into from
Closed

Changes to fSCA and SNOTEL #6

wants to merge 14 commits into from

Conversation

manasa123104
Copy link
Collaborator

No description provided.

@gokulprathin8
Copy link
Collaborator

please merge fSCA training and testing into a single chapter

@manasa123104 manasa123104 marked this pull request as ready for review March 31, 2024 03:59
@manasa123104 manasa123104 requested a review from ZihengSun March 31, 2024 04:00
@saivivek116
Copy link
Collaborator

saivivek116 commented Apr 2, 2024

can you pls check the markdown of the headings
there is not separation between heading and its contents
use bold text for headings and use : or new line for seperation
for proper markdown usage
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
refer this
and review your changes in the preview

@saivivek116
Copy link
Collaborator

No Code related to fSCA training, fSCA testing and data_snotel_stations process nodes in the books.
can you pls add Code and its explanation for the better understanding.

@saivivek116 saivivek116 self-requested a review April 2, 2024 00:20
book/chapters/fsCA.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown is very messy. Please correct. Also, get the chapter logic together. It doesn't make any sense right now.

@manasa123104 manasa123104 changed the title Changes to fSCA and SNOTEl Changes to fSCA and SNOTEL Apr 3, 2024
@gokulprathin8
Copy link
Collaborator

snotel review:
snotel.pdf

@gokulprathin8
Copy link
Collaborator

fSCA review:
fsCA.pdf

@ZihengSun
Copy link
Collaborator

probably shouldn't remove the three data files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants