Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: sci-libs/torchaudio #1310

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

New package: sci-libs/torchaudio #1310

wants to merge 6 commits into from

Conversation

uis246
Copy link

@uis246 uis246 commented Jan 2, 2025

No description provided.

@uis246
Copy link
Author

uis246 commented Jan 2, 2025

https://bugs.gentoo.org/947281

@uis246
Copy link
Author

uis246 commented Jan 2, 2025

Torchaudio tests are broken and need additional package

@uis246 uis246 changed the title Add torchaudio New package: sci-libs/torchaudio Jan 2, 2025
Nowa-Ammerlaan
Nowa-Ammerlaan reviewed Jan 2, 2025
View reviewed changes
dev-python/soundfile/soundfile-0.12.1.ebuild Outdated Show resolved Hide resolved
dev-python/soundfile/soundfile-0.12.1.ebuild Outdated Show resolved Hide resolved
sci-libs/torchaudio/torchaudio-2.4.1.ebuild Outdated Show resolved Hide resolved
sci-libs/torchaudio/torchaudio-2.4.1.ebuild Outdated Show resolved Hide resolved
sci-libs/torchaudio/torchaudio-2.4.1.ebuild Outdated Show resolved Hide resolved
@uis246 uis246 force-pushed the master branch 2 times, most recently from 6bc9b2a to 5f2d8be Compare January 2, 2025 14:30
@uis246
Copy link
Author

uis246 commented Jan 2, 2025

Torchaudio still does not pass all tests because it needs librosa, adding which depends on #1286.

@uis246
Copy link
Author

uis246 commented Jan 2, 2025 •
edited
Loading

What is the best way to express that enabling or disabling soundfile should not cause rebuild? At least disabling even with tests enabled.

EDIT: eh. Nevermind.

@Nowa-Ammerlaan
Copy link
Member

What is the best way to express that enabling or disabling soundfile should not cause rebuild? At least disabling even with tests enabled.

optfeature.eclass, it should not be a RDEPEND if it does not need to be rebuilt.

@Nowa-Ammerlaan
Copy link
Member

Nowa-Ammerlaan commented Jan 3, 2025 •
edited
Loading

Could you please sign-off your commits in accordance with the copyright policy?

@uis246
Copy link
Author

uis246 commented Jan 3, 2025

Done

@Nowa-Ammerlaan
Copy link
Member

Do you want to wait for #1286 , or shall I test (and merge if it works) now?

@uis246
Copy link
Author

uis246 commented Jan 4, 2025 •
edited
Loading

Probably merge now.
Right now it would obviously fail tests related to librose, so I disabled tests requiring it and one seemingly infinite test.
I have tests running now and already noticed few failing integration tests. Current guess is they need librose too, will look at test results when they finish.
I can't run cuda-related tests for lack of hardware.

@uis246
Copy link
Author

uis246 commented Jan 5, 2025

I OOMed on tests, so I can't just read error log.
Some integration tests require downloading additional data, other I have no idea why fail. Probably for same reason.
Unit tests pass mostly. Some ffmpeg-related tests fail.

@uis246
sci-libs/torchaudio: require <ffmpeg-7
00579a3 
According to termux/termux-packages#22502 and pytorch/audio#385 ffmpeg-7
is not yet supported upstream.

Signed-off-by: uis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nowa-Ammerlaan Nowa-Ammerlaan Nowa-Ammerlaan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uis246 @Nowa-Ammerlaan